Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run tests for simple cabal projects #44

Merged

Conversation

saep
Copy link
Contributor

@saep saep commented Feb 26, 2023

Description of changes

I've added the ability to run tests on simple cabal projects (such as https://github.com/neovimhaskell/nvim-hs).

Since I'm using nix flakes, I typically don't have any extraneous build tools (such as stack) installed. That's why I added the check for a stack executable. This should be backwards compatible and allow people like me to use cabal instead of stack on normal projects without a project.cabal.

Things done
  • Tested, as applicable:
    • Added plenary specs: Is the pipeline capable of running cabal test?
    • Manually
  • Updated CHANGELOG.md (if applicable).
  • Fits CONTRIBUTING.md

@mrcjkb
Copy link
Owner

mrcjkb commented Feb 26, 2023

Thanks for the contribution!

lua/neotest-haskell/cabal.lua Outdated Show resolved Hide resolved
lua/neotest-haskell/init.lua Outdated Show resolved Hide resolved
@mrcjkb
Copy link
Owner

mrcjkb commented Feb 26, 2023

To answer your question about adding plenary specs: I haven't had time to figure out how best to write integration tests for this plugin yet.
It's definitely on my agenda. But until then, we have to make do with manual tests 😞

@mrcjkb
Copy link
Owner

mrcjkb commented Feb 26, 2023

It looks like the changelog entry is missing?

@saep saep force-pushed the feature/run-tests-for-simple-cabal-projects branch from 2615524 to 666f546 Compare February 26, 2023 20:14
@mrcjkb mrcjkb changed the title Feature/run tests for simple cabal projects feat: run tests for simple cabal projects Feb 26, 2023
@saep saep force-pushed the feature/run-tests-for-simple-cabal-projects branch from 666f546 to 2a1678a Compare February 26, 2023 21:07
@saep saep force-pushed the feature/run-tests-for-simple-cabal-projects branch from 2a1678a to 1f8dd4a Compare February 27, 2023 20:51
Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thanks for all the work!

@mrcjkb mrcjkb merged commit 4d407e2 into mrcjkb:master Feb 28, 2023
@mrcjkb
Copy link
Owner

mrcjkb commented Feb 28, 2023

@all-contributors please add @saep for code

@allcontributors
Copy link
Contributor

@mrcjkb

I've put up a pull request to add @saep! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants