Skip to content

Commit

Permalink
lower phpunit version to run with php 5.3 on travis
Browse files Browse the repository at this point in the history
  • Loading branch information
@glensc
glensc committed Nov 22, 2015
1 parent 492222d commit 6f923c6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion composer.json
View file
Expand Up @@ -32,7 +32,7 @@
"require-dev": {
"leafo/lessphp": "~0.4.0",
"meenie/javascript-packer": "~1.1",
"phpunit/phpunit": "5.0.*"
"phpunit/phpunit": "4.8.*"
},
"suggest": {
"leafo/lessphp": "LESS support",
Expand Down

6 comments on commit 6f923c6

@GrahamCampbell
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lock file needs updating

@glensc
Copy link
Collaborator Author

@glensc glensc commented on 6f923c6 Nov 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i dislike committing lockfile to git. i don't do that in my own projects.

@GrahamCampbell
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glensc You surely need to actually remove it then?

@glensc
Copy link
Collaborator Author

@glensc glensc commented on 6f923c6 Nov 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would remove it (remove composer.lock from git), but @mrclay has final word on this, i guess

@mrclay
Copy link
Owner

@mrclay mrclay commented on 6f923c6 Nov 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the lock and add it to gitignore.

@glensc
Copy link
Collaborator Author

@glensc glensc commented on 6f923c6 Nov 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yap, #492

Please sign in to comment.