Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

height/width calculations fail on framesets #22

Closed
pjvandehaar opened this issue Aug 25, 2014 · 3 comments
Closed

height/width calculations fail on framesets #22

pjvandehaar opened this issue Aug 25, 2014 · 3 comments

Comments

@pjvandehaar
Copy link

Eg, http://www.quackit.com/html/templates/frames/frames_example_1.html.

document.documentElement.scrollHeight, etc are all window.innerHeight.

@pjvandehaar
Copy link
Author

Oh, window.scrollTo doesn't work on a frameset. Better option:

if(document.querySelectorAll('frameset').length>0) {
  alert('Sorry, this page is a frameset, which is not supported');
}

@mrcoles
Copy link
Owner

mrcoles commented Feb 5, 2018

I’m leaving out frameset support for now. You can checkout some workarounds in #58

@mrcoles mrcoles closed this as completed Feb 5, 2018
@pjvandehaar
Copy link
Author

That seems like a good choice. I still think it'd be good to let users know what's going on when the extension fails on a frameset (as per #22 (comment)), but you're free to do whatever you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants