Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpeedShare auto update question #1

Closed
MRColorR opened this issue Feb 11, 2024 · 5 comments
Closed

SpeedShare auto update question #1

MRColorR opened this issue Feb 11, 2024 · 5 comments

Comments

@MRColorR
Copy link
Owner

Hello, and thank you for your amazing work on this project. I've been exploring the image and have some thoughts and questions that might help enhance it further:

  • It appears the app's installation occurs at runtime via the entrypoint, ensuring the latest version upon first run. However, this approach seems to bypass updates for existing instances and causes a new device to appear on every restart. Could an alternative method ensure continuous updates without sacrificing the benefits of your current strategy?
    • I've noticed potential issues with the device UUID changing with each image update, potentially cluttering the dashboard with multiple device entries. Would it be feasible to allow a persistent UUID through an environment variable for consistency?
  • For updates and to install the app direcly in the image building phase, perhaps implementing an MD5 checksum in the GitHub Actions could automate version checks and updates (download app check md5sum if different from the saved one then procees with installing and building steps), pushing these directly to Docker Hub, ready to use.
    • Lastly, as an alternative, considering the speedshare CLI's update command, might there be a way to incorporate automatic updates within running containers, maybe through a scheduled task or similar mechanism this is suboptimal for containers but worth exploring)

These are just some initial thoughts. I'm looking forward to hearing your insights and discussing potential improvements

@ElDavoo
Copy link
Collaborator

ElDavoo commented Feb 11, 2024

Hello, and thank you for your amazing work on this project.

Thanks to you for the amazing money4band project! The speedshare container is a direct result of seeing the websites supported by your project.

These are just some initial thoughts. I'm looking forward to hearing your insights and discussing potential improvements

All you said is true, but I don't want to spend time on this project (for now), I don't consider it important (even because the payout from my area is really minimal). I will accept PRs or if you're happy with that I can transfer the ownership of the project :)

@MRColorR
Copy link
Owner Author

Hello, and thank you for your amazing work on this project.

Thanks to you for the amazing money4band project! The speedshare container is a direct result of seeing the websites supported by your project.

These are just some initial thoughts. I'm looking forward to hearing your insights and discussing potential improvements

All you said is true, but I don't want to spend time on this project (for now), I don't consider it important (even because the payout from my area is really minimal). I will accept PRs or if you're happy with that I can transfer the ownership of the project :)

Thank you for your response and for considering my suggestions. I'm honored that my project inspired you and i'm even more honored by the opportunity to contribute more significantly to the project. Given your current stance, I would be glad to take on a more active role, accepting the ownership transfer. This project has great potential, and I'm excited about the prospect of enhancing it further with you. Let's coordinate the next steps for a smooth transition and collaboration. Thanks again for your openness and trust i really appreciate it.

@ElDavoo
Copy link
Collaborator

ElDavoo commented Feb 11, 2024

OK, you'll need to delete your fork first

@MRColorR
Copy link
Owner Author

OK, you'll need to delete your fork first

Ok, i've deleted it.

As a token of appreciation for your contributions and to honor your role in this project's development, I'd like to give you the contributors role within the Money4Band Discord community. Let me know if this aligns with your interest too.

@ElDavoo
Copy link
Collaborator

ElDavoo commented Feb 11, 2024

Sounds right! Transfer requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants