Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

first step CI support (Travis CI) #6

Merged
merged 7 commits into from
Jun 1, 2018
Merged

first step CI support (Travis CI) #6

merged 7 commits into from
Jun 1, 2018

Conversation

wdv4758h
Copy link
Contributor

@wdv4758h wdv4758h commented Jun 1, 2018

Here is the intial Travis CI settings, I can see it build hyperjson and run the test cases. There are some test cases failing though.

@mre
Copy link
Owner

mre commented Jun 1, 2018

Whoa, that's great news @wdv4758h!
Yeah the failing tests are a thing we need to fix next.
It shouldn't be that many, so I guess we can fix or skip them one by one.
I guess I'll create a ticket for that.

@mre mre mentioned this pull request Jun 1, 2018
addons:
apt:
packages:
- rpm
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that required?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, that's for building the rpm package. All good!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, that for rpm package, but this PR does not finish the packaging part though

- rpm

python:
#- 2.7
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 2.7 used to work I guess. Haven't tested it in a while, though.
Maybe we can give it a shot?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, it can build, but the test cases can't run at all. It fails at from json import JSONDecodeError.

which rustc
rustc --version
# pip install -r requirements.txt
pip freeze
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess that's not needed, right?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whelp, or maybe we should keep it for troubleshooting build logs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this one is just to make sure what's in the environment.

@mre
Copy link
Owner

mre commented Jun 1, 2018

Good work!

@wdv4758h
Copy link
Contributor Author

wdv4758h commented Jun 1, 2018

This PR only implement the build and test part, and it's only running for Linux x86_64. (there are some settings for packaging that I copy from my other project though)

@wdv4758h
Copy link
Contributor Author

wdv4758h commented Jun 1, 2018

here is the current fail list:

tests/test_ujson.py::UltraJSONTests::testEncodeSymbols FAILED                      
tests/test_ujson.py::UltraJSONTests::testEncodeUnicodeBMP FAILED                   
tests/test_ujson.py::UltraJSONTests::test_WriteArrayOfSymbolsFromList FAILED       
tests/test_ujson.py::UltraJSONTests::test_WriteArrayOfSymbolsFromTuple FAILED      
tests/test_ujson.py::UltraJSONTests::test_decodeArrayDepthTooBig FAILED            
tests/test_ujson.py::UltraJSONTests::test_decodeBigEscape FAILED                   
tests/test_ujson.py::UltraJSONTests::test_decodeWithTrailingNonWhitespaces FAILED  
tests/test_ujson.py::UltraJSONTests::test_dumpToFile FAILED                        
tests/test_ujson.py::UltraJSONTests::test_dumpToFileLikeObject FAILED              
tests/test_ujson.py::UltraJSONTests::test_encodeListLongUnsignedConversion FAILED  
tests/test_ujson.py::UltraJSONTests::test_encodeLongUnsignedConversion FAILED      
tests/test_ujson.py::UltraJSONTests::test_encodeOrderedDict FAILED                 
tests/test_ujson.py::UltraJSONTests::test_loadFileLikeObject FAILED                
tests/test_ujson.py::UltraJSONTests::test_sortKeys FAILED                          

@mre mre merged commit a0ee9ef into mre:master Jun 1, 2018
@mre
Copy link
Owner

mre commented Jun 1, 2018

Thanks for that! ⭐️

@mre
Copy link
Owner

mre commented Jun 1, 2018

Oh, just some background info: the reason why I already merged this is, that I think will motivate us to fix the remaining 14 unit tests and earn a green badge in the README.md. Also, it's already pretty solid and we can extend it as we go. 😉

@wdv4758h wdv4758h deleted the ci branch June 2, 2018 04:30
@mre mre mentioned this pull request Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants