Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

Add orjson to benchmark suite #64

Merged
merged 1 commit into from
Sep 21, 2019
Merged

Conversation

packysauce
Copy link
Contributor

fixes #62

it's pretty quick!

@mre
Copy link
Owner

mre commented Sep 21, 2019

Cool! Thanks @packysauce. ✌️

@mre mre merged commit fd79077 into mre:master Sep 21, 2019
@mre
Copy link
Owner

mre commented Sep 21, 2019

it's pretty quick!

It's indeed pretty fast. The cost, however, is more unsafe code:

Not saying this is necessarily bad; it's just a design decision that they made.

I believe that it should be possible to reach similar performance without unsafe code.
For that, we'd have to do some more profiling to find bottlenecks and find better ways to make use of Rust's strengths. For example, by refactoring the codebase we could make use of parallel encoding/decoding. We could then use rust-evmap to build up a hashmap datastructure in a lockless way.
That's just an example and it might not be that easy, but adding such functionality to a codebase with a lot of unsafe code can be quite difficult from my experience. 😉

Now I wonder if I should create an issue for that to give it a try... 🤔

@alexprengere alexprengere mentioned this pull request Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compare with orjson
2 participants