Skip to content

Commit

Permalink
Fix style invalidation bug of logical combinations inside :has().
Browse files Browse the repository at this point in the history 
A sibling change doesn't trigger style invalidation properly when
a :has() contains a logical combination containing a sibling
relationship:

<style>
  .subject { color: green }
  .subject:has(:is(.sibling + .child)) { color: red }
</style>
<div id="subject" class="subject">
  <div id="sibling" class="sibling"></div>
  <div class="child">Must be green</div>
</div>
<script>
  document.body.offsetLeft;
  sibling.classList.remove("sibling");
  document.body.offsetLeft;
  // The text must be green but red
</script>

CheckPseudoHasArgumentContext extracts sibling relationship
information from adjacent combinators inside ':has()' and provides
the information to SelectorChecker so that SelectorChecker marks
following flags:
- AncestorsOrAncestorSiblingsAffectedByHas
- SiblingsAffectedByHas

But the extraction logic haven't considered the adjacent combinators
or sibling relationships in the sub-selector of a logical combination
inside ':has()'. (e.g. :has(:is(.a + .b)), :has(:not(:nth-child(2))))

This CL fixes the bug by extracting sibling relationship information
from a sub-selector of :is(), :where() or :not() inside :has().

Bug: 1448531
Change-Id: Ifd5b0db33d357c530a5b8e467f2a7838e86f9528
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4576376
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Byungwoo Lee <blee@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1164385}
  • Loading branch information
@byung-woo @chromium-wpt-export-bot
byung-woo authored and chromium-wpt-export-bot committed Jun 29, 2023
1 parent fc6fe9d commit 0dfc2ab
Show file tree
Hide file tree
Showing 2 changed files with 360 additions and 0 deletions.
311 changes: 311 additions & 0 deletions css/selectors/invalidation/is-pseudo-containing-sibling-relationship-in-has.html
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,311 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>CSS Selectors Test: :has(:is()) invalidation for sibling change</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<link rel="help" href="https://drafts.csswg.org/selectors/#relational">
<style>
#test-container > div { background-color: green; }
#target1:has(:is(.item + .item + .item)) { background-color: red; }
#target2:has(:is(.invalid .item, .item + .item + .item)) { background-color: red; }
#target3:has(:is(.item + .item + .item > .child + .child + .child)) { background-color: red; }
#target4:has(:is(.item + .item + .item > .child):is(.child + .child + .child)) { background-color: red; }
#target5:has(:is(.item + .item + .item > .child)) { background-color: red; }
#target6:has(:is(.invalid .item, .item + .item + .item > .child)) { background-color: red; }
#target7:has(:is(.item + .item + .item > .child + .child + .child)) { background-color: red; }
#target8:has(:is(.child + .child + .child):is(.item + .item + .item > .child)) { background-color: red; }
#target9:has(:is(:where(:is(.item + .item + .item) > .child) + .child + .child)) { background-color: red; }
#target10:has(:is(.item:nth-child(3))) { background-color: red; }
#target11:has(:is(.item:nth-child(3) > .child:nth-child(3))) { background-color: red; }
#target12:has(:is(.item:nth-last-child(3))) { background-color: red; }
#target13:has(:is(.item:nth-last-child(3) > .child:nth-last-child(3))) { background-color: red; }
#target14:has(:is(.item:nth-child(3) > .child)) { background-color: red; }
#target15:has(:is(.item:nth-child(3) > .child:nth-child(3))) { background-color: red; }
#target16:has(:is(.item:nth-last-child(3) > .child)) { background-color: red; }
#target17:has(:is(.item:nth-last-child(3) > .child:nth-last-child(3))) { background-color: red; }
.item + .item + .item {
#target18:has(&) { background-color: red; }
#target19:has(:is(& > .child + .child + .child)) { background-color: red; }
}
.item + .item + .item > .child {
#target20:has(:is(& + .child + .child)) { background-color: red; }
}
</style>
<div id="test-container">
<div id="target1">
<div class="item" id="item1">FAIL if you see this text</div>
<div class="item"></div>
<div class="item">This text should have a green background</div>
</div>
<div id="target2">
<div class="item" id="item2">FAIL if you see this text</div>
<div class="item"></div>
<div class="item">This text should have a green background</div>
</div>
<div id="target3">
<div class="item"></div>
<div class="item"></div>
<div class="item">
<span class="child" id="item3">(FAIL if you see this text)</span>
<span class="child"></span>
<span class="child">This text should have a green background</span>
</div>
</div>
<div id="target4">
<div class="item"></div>
<div class="item"></div>
<div class="item">
<span class="child" id="item4">(FAIL if you see this text)</span>
<span class="child"></span>
<span class="child">This text should have a green background</span>
</div>
</div>
<div id="target5">
<div class="item" id="item5">FAIL if you see this text</div>
<div class="item"></div>
<div class="item">
<span class="child">This text should have a green background</span>
</div>
</div>
<div id="target6">
<div class="item" id="item6">FAIL if you see this text</div>
<div class="item"></div>
<div class="item">
<span class="child">This text should have a green background</span>
</div>
</div>
<div id="target7">
<div class="item"></div>
<div class="item" id="item7">FAIL if you see this text</div>
<div class="item">
<span class="child"></span>
<span class="child"></span>
<span class="child">This text should have a green background</span>
</div>
</div>
<div id="target8">
<div class="item"></div>
<div class="item" id="item8">FAIL if you see this text</div>
<div class="item">
<span class="child"></span>
<span class="child"></span>
<span class="child">This text should have a green background</span>
</div>
</div>
<div id="target9">
<div class="item"></div>
<div class="item" id="item9">FAIL if you see this text</div>
<div class="item">
<span class="child"></span>
<span class="child"></span>
<span class="child">This text should have a green background</span>
</div>
</div>
<div id="target10">
<div class="item" id="item10">FAIL if you see this text</div>
<div class="item"></div>
<div class="item">This text should have a green background</div>
</div>
<div id="target11">
<div class="item"></div>
<div class="item"></div>
<div class="item">
<span class="child" id="item11">(FAIL if you see this text)</span>
<span class="child"></span>
<span class="child">This text should have a green background</span>
</div>
</div>
<div id="target12">
<div class="item">This text should have a green background</div>
<div class="item"></div>
<div class="item" id="item12">FAIL if you see this text</div>
</div>
<div id="target13">
<div class="item">
<span class="child">This text should have a green background</span>
<span class="child"></span>
<span class="child" id="item13">(FAIL if you see this text)</span>
</div>
<div class="item"></div>
<div class="item"></div>
</div>
<div id="target14">
<div class="item" id="item14">FAIL if you see this text</div>
<div class="item"></div>
<div class="item">
<span class="child">This text should have a green background</span>
</div>
</div>
<div id="target15">
<div class="item" id="item15">FAIL if you see this text</div>
<div class="item"></div>
<div class="item">
<span class="child"></span>
<span class="child"></span>
<span class="child">This text should have a green background</span>
</div>
</div>
<div id="target16">
<div class="item">
<span class="child">This text should have a green background</span>
</div>
<div class="item"></div>
<div class="item" id="item16">FAIL if you see this text</div>
</div>
<div id="target17">
<div class="item">
<span class="child">This text should have a green background</span>
<span class="child"></span>
<span class="child"></span>
</div>
<div class="item"></div>
<div class="item" id="item17">FAIL if you see this text</div>
</div>
<div id="target18">
<div class="item" id="item18">FAIL if you see this text</div>
<div class="item"></div>
<div class="item">This text should have a green background</div>
</div>
<div id="target19">
<div class="item"></div>
<div class="item" id="item19">FAIL if you see this text</div>
<div class="item">
<span class="child"></span>
<span class="child"></span>
<span class="child">This text should have a green background</span>
</div>
</div>
<div id="target20">
<div class="item"></div>
<div class="item" id="item20">FAIL if you see this text</div>
<div class="item">
<span class="child"></span>
<span class="child"></span>
<span class="child">This text should have a green background</span>
</div>
</div>
</div>
<script>
test(() => {
assert_equals(getComputedStyle(target1).backgroundColor, "rgb(255, 0, 0)");
assert_equals(getComputedStyle(target2).backgroundColor, "rgb(255, 0, 0)");
assert_equals(getComputedStyle(target3).backgroundColor, "rgb(255, 0, 0)");
assert_equals(getComputedStyle(target4).backgroundColor, "rgb(255, 0, 0)");
assert_equals(getComputedStyle(target5).backgroundColor, "rgb(255, 0, 0)");
assert_equals(getComputedStyle(target6).backgroundColor, "rgb(255, 0, 0)");
assert_equals(getComputedStyle(target7).backgroundColor, "rgb(255, 0, 0)");
assert_equals(getComputedStyle(target8).backgroundColor, "rgb(255, 0, 0)");
assert_equals(getComputedStyle(target9).backgroundColor, "rgb(255, 0, 0)");
assert_equals(getComputedStyle(target10).backgroundColor, "rgb(255, 0, 0)");
assert_equals(getComputedStyle(target11).backgroundColor, "rgb(255, 0, 0)");
assert_equals(getComputedStyle(target12).backgroundColor, "rgb(255, 0, 0)");
assert_equals(getComputedStyle(target13).backgroundColor, "rgb(255, 0, 0)");
assert_equals(getComputedStyle(target14).backgroundColor, "rgb(255, 0, 0)");
assert_equals(getComputedStyle(target15).backgroundColor, "rgb(255, 0, 0)");
assert_equals(getComputedStyle(target16).backgroundColor, "rgb(255, 0, 0)");
assert_equals(getComputedStyle(target17).backgroundColor, "rgb(255, 0, 0)");
assert_equals(getComputedStyle(target18).backgroundColor, "rgb(255, 0, 0)");
assert_equals(getComputedStyle(target19).backgroundColor, "rgb(255, 0, 0)");
assert_equals(getComputedStyle(target20).backgroundColor, "rgb(255, 0, 0)");
}, "Initially red");

test(() => {
item1.remove();
assert_equals(getComputedStyle(target1).backgroundColor, "rgb(0, 128, 0)");
}, "sibling selector enclosed by :is() no longer matching after removal (1)");

test(() => {
item2.remove();
assert_equals(getComputedStyle(target2).backgroundColor, "rgb(0, 128, 0)");
}, "sibling selector enclosed by :is() no longer matching after removal (2)");

test(() => {
item3.remove();
assert_equals(getComputedStyle(target3).backgroundColor, "rgb(0, 128, 0)");
}, "sibling selector enclosed by :is() no longer matching after removal (3)");

test(() => {
item4.remove();
assert_equals(getComputedStyle(target4).backgroundColor, "rgb(0, 128, 0)");
}, "sibling selector enclosed by :is() no longer matching after removal (4)");

test(() => {
item5.remove();
assert_equals(getComputedStyle(target5).backgroundColor, "rgb(0, 128, 0)");
}, "sibling selector in non-subject enclosed by :is() no longer matching after removal (1)");

test(() => {
item6.remove();
assert_equals(getComputedStyle(target6).backgroundColor, "rgb(0, 128, 0)");
}, "sibling selector in non-subject enclosed by :is() no longer matching after removal (2)");

test(() => {
item7.remove();
assert_equals(getComputedStyle(target7).backgroundColor, "rgb(0, 128, 0)");
}, "sibling selector in non-subject enclosed by :is() no longer matching after removal (3)");

test(() => {
item8.remove();
assert_equals(getComputedStyle(target8).backgroundColor, "rgb(0, 128, 0)");
}, "sibling selector in non-subject enclosed by :is() no longer matching after removal (4)");

test(() => {
item9.remove();
assert_equals(getComputedStyle(target9).backgroundColor, "rgb(0, 128, 0)");
}, "sibling selector in non-subject enclosed by :is() no longer matching after removal (5)");

test(() => {
item10.remove();
assert_equals(getComputedStyle(target10).backgroundColor, "rgb(0, 128, 0)");
}, ":nth-child() enclosed by :is() no longer matching after removal (1)");

test(() => {
item11.remove();
assert_equals(getComputedStyle(target11).backgroundColor, "rgb(0, 128, 0)");
}, ":nth-child() enclosed by :is() no longer matching after removal (2)");

test(() => {
item12.remove();
assert_equals(getComputedStyle(target12).backgroundColor, "rgb(0, 128, 0)");
}, ":nth-last-child() enclosed by :is() no longer matching after removal (1)");

test(() => {
item13.remove();
assert_equals(getComputedStyle(target13).backgroundColor, "rgb(0, 128, 0)");
}, ":nth-last-child() enclosed by :is() no longer matching after removal (2)");

test(() => {
item14.remove();
assert_equals(getComputedStyle(target14).backgroundColor, "rgb(0, 128, 0)");
}, ":nth-child() in non-subject enclosed by :is() no longer matching after removal (1)");

test(() => {
item15.remove();
assert_equals(getComputedStyle(target15).backgroundColor, "rgb(0, 128, 0)");
}, ":nth-child() in non-subject enclosed by :is() no longer matching after removal (2)");

test(() => {
item16.remove();
assert_equals(getComputedStyle(target16).backgroundColor, "rgb(0, 128, 0)");
}, ":nth-last-child() in non-subject enclosed by :is() no longer matching after removal (1)");

test(() => {
item17.remove();
assert_equals(getComputedStyle(target17).backgroundColor, "rgb(0, 128, 0)");
}, ":nth-last-child() in non-subject enclosed by :is() no longer matching after removal (2)");

test(() => {
item18.remove();
assert_equals(getComputedStyle(target18).backgroundColor, "rgb(0, 128, 0)");
}, "sibling selector in parent selector enclosed by :is() no longer matching after removal");

test(() => {
item19.remove();
assert_equals(getComputedStyle(target19).backgroundColor, "rgb(0, 128, 0)");
}, "sibling selector in parent selector non-subject position enclosed by :is() no longer matching after removal (1)");

test(() => {
item20.remove();
assert_equals(getComputedStyle(target20).backgroundColor, "rgb(0, 128, 0)");
}, "sibling selector in parent selector non-subject position enclosed by :is() no longer matching after removal (2)");
</script>
49 changes: 49 additions & 0 deletions css/selectors/invalidation/not-pseudo-containing-sibling-relationship-in-has.html
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>CSS Selectors Test: :has(:not()) invalidation for sibling change</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<link rel="help" href="https://drafts.csswg.org/selectors/#relational">
<style>
#test-container > div { background-color: green; }
#target1:has(:not(.item, :nth-child(3))) { background-color: red; }
#target2:has(:not(.item, :nth-last-child(3))) { background-color: red; }
</style>
<div id="test-container">
<div id="target1">
<div class="item"></div>
<div id="item1">This text should have a green background</div>
</div>
<div id="target2">
<div id="item2">This text should have a green background</div>
<div class="item"></div>
</div>
</div>
<script>
test(() => {
assert_equals(getComputedStyle(target1).backgroundColor, "rgb(255, 0, 0)");
assert_equals(getComputedStyle(target2).backgroundColor, "rgb(255, 0, 0)");
}, "Initially red");

function insertDivItemBefore(item) {
let div = document.createElement("div");
div.classList.add("item");
item.parentElement.insertBefore(div, item);
}

function insertDivItemAfter(item) {
let div = document.createElement("div");
div.classList.add("item");
item.parentElement.append(div, item.nextSibling);
}

test(() => {
insertDivItemBefore(item1);
assert_equals(getComputedStyle(target1).backgroundColor, "rgb(0, 128, 0)");
}, ":nth-child() enclosed by :not() matching after insertion");

test(() => {
insertDivItemAfter(item2);
assert_equals(getComputedStyle(target2).backgroundColor, "rgb(0, 128, 0)");
}, ":nth-last-child() enclosed by :not() matching after insertion");
</script>

0 comments on commit 0dfc2ab

Please sign in to comment.