Combine header and search form #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change gives more space to definitions and examples, which is particularly important on smaller screens. A logo is substituted for the text header in the main view, and the text header is re-shown (without the search form) in menu and stats views. TODO: is the logo right, or would an abbreviated text header be better?
|
Visit the preview URL for this PR (updated for commit 743a959): https://hanzigraph--pr20-less-header-x2kk0cwi.web.app (expires Mon, 29 Jan 2024 16:20:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dbfc59c053d815dc5dedbd48d2959ec4a33d1b39 |
|
never mind |
With some brittle CSS, oh well
This still allows more than hanzi matches, given the ability to search with and without tones.
This prevents UI jank while typing, as previously tokenization was happening on the main thread. This does increase search suggestion worker memory, however, and upcoming commits will need to find a way to decrease that. The incompatibility between CEDICT and jieba/Intl stuff remains a TODO (especially with the nasty vetCandidate function). Custom dictionaries should help.
This change gives more space to definitions and examples, which is particularly important on smaller screens. A logo is substituted for the text header in the main view, and the text header is re-shown (without the search form) in menu and stats views. TODO: is the logo right, or would an abbreviated text header be better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change gives more space to definitions and examples, which is particularly important on smaller screens. A logo is substituted for the text header in the main view, and the text header is re-shown (without the search form) in menu and stats views. TODO: is the logo right, or would an abbreviated text header be better?