Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only special case empty Hanzi Math results of subtraction #47

Merged
merged 1 commit into from
Jul 14, 2024

Commits on Jul 14, 2024

  1. Only special case empty math results due to subtraction

    Previously, operations like 我+你+我 would return results.
    This was because empty results of prior operations effectively
    reset the result, but we only want that with subtraction.
    我+你+我 now returns [].
    
    Note that this does not address self-adds, which are still broken.
    It also continues adding all parents in cases like: 我-我+我.
    The same transitivity is true for normal operations (so 力+口
    returns many characters with 另 or 加 as a component, intentionally).
    mreichhoff committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    a5dd886 View commit details
    Browse the repository at this point in the history