Update parameters.js #7
Conversation
(Change 1): Changed the options from ['-5V to +5V', '0V to 10V'] to ['0V to +5V', '0V to +10V'] for 'KB VEL OUT Range', 'Arp/Sep VEL OUT Range', 'KB AT OUT Range', and 'MOD WHL OUT Range'. (Change 2): Changed '0V to 10V' to '0V to +10V' on 'KB CV OUT Range' and 'Arp/Seq CV OUT Range' (to match the notation in the manual). (Change 3): Changed 'KB GATE OUT Range' and 'Arp/Seq GATE OUT Range' to '... GATE OUT Magnitude' and changed the options from ['-5V to +5V', '0V to 10V'] to ['+5V', '+10V'] (to match the manual).
|
I am incredibly grateful that you created and shared this tool. You have done quite a service for the Matriarch users of the world. Further info regarding the proposed changes— Change 1: I consider "necessary", as it corrects the fact that 'KB VEL OUT Range', 'Arp/Sep VEL OUT Range', 'KB AT OUT Range', and 'MOD WHL OUT Range' all currently state having the options of ['-5V to +5V', '0V to 10V'], whereas the options are actually (per the manual and confirmed through my experience with the Matriarch) ['0V to +5V', '0V to +10V'] (no negative values). Change 2: I consider "optional" (but recommended), as it is simply to match the notation in the manual ("+10V" instead of "10V"). Change 3: I consider "necessary", as the currently stated ['-5V to +5V', '0V to 10V'] is incorrect (as the gate signal is never negative). I changed the word "range" (to "magnitude"), as when then gate is not 0, it is simply +5V (or +10V) (per the manual). |
|
Hi Chris, Thanks for catching those issues and putting up the PR. I agree with all those changes except for changing the two uses of "Range" to "Magnitude". I can see why it makes more sense to call them magnitudes rather than ranges but I'd prefer to keep the parameter names consistent with the manual, which calls them "KB GATE OUT Range" and "Arp/Seq GATE OUT Range". I've just merged those fixes (minus the "Magnitude" change) in using a new patchset. It also updates the main page to add you as a contributor. Thanks again, Mark |
(Change 1): Changed the options from ['-5V to +5V', '0V to 10V'] to ['0V to +5V', '0V to +10V'] for 'KB VEL OUT Range', 'Arp/Sep VEL OUT Range', 'KB AT OUT Range', and 'MOD WHL OUT Range'.
(Change 2): Changed '0V to 10V' to '0V to +10V' on 'KB CV OUT Range' and 'Arp/Seq CV OUT Range' (to match the notation in the manual).
(Change 3): Changed 'KB GATE OUT Range' and 'Arp/Seq GATE OUT Range' to '... GATE OUT Magnitude' and changed the options from ['-5V to +5V', '0V to 10V'] to ['+5V', '+10V'] (to match the manual).