Skip to content
This repository has been archived by the owner on Jan 24, 2020. It is now read-only.

Upgrade from Beta to Release of Bootstrap 4 #18

Closed
mrellipse opened this issue Feb 3, 2018 · 11 comments
Closed

Upgrade from Beta to Release of Bootstrap 4 #18

mrellipse opened this issue Feb 3, 2018 · 11 comments

Comments

@mrellipse
Copy link
Owner

No description provided.

@mrellipse mrellipse self-assigned this Feb 3, 2018
@bjammin
Copy link

bjammin commented Feb 7, 2018

Just a note for when this gets done. Bootstrap 4 beta seems to deprecate use of _custom.scss and it doesn't seem to work in this project as of now (changes to this file have no effect).

So when bootstrap 4 release is added please ensure there is a way of adding custom variable values without modifying the core files.

Reference:
https://stackoverflow.com/questions/45651432/bootstrap-4-scss-overrides-not-working

Thanks!

@bjammin
Copy link

bjammin commented Feb 9, 2018

Also it would be really handy to implement bootstrap-vue as none of the bootstrap javascript components work currently (eg. the nav in mobile mode)

https://bootstrap-vue.js.org/

@mrellipse
Copy link
Owner Author

ah, it's now vue-bootstrap@4

I didn't expect bootstrap 4 to be in alpha for so long! so I held off adding bootstrap-vue until v4 was official

you asked about making pull requests before ... would you be willing to contribute one for vue-bootstrap? it's a pretty substantial piece of work to ask for, but github can offer you many fake internet points in return ;)

@bjammin
Copy link

bjammin commented Feb 11, 2018

I'd certainly be willing, but I'm such a noob with vue and the whole webpack process. I'm not even sure which option to use to get started.

If you could point me in the right direction and give me a few notes I'd be happy to have a go.

@mrellipse
Copy link
Owner Author

:+1

no guts no glory.

alrighty, i will do some research and drop you an email! webpack can definitely be intimidating at first - but it's basically just a series of input/output pipes. You configure each step in the chain to filter the data inputs, operate on the selected inputs/files, and then produce one (or many) new outputs.

@mrellipse
Copy link
Owner Author

mrellipse commented Feb 13, 2018 via email

@mrellipse
Copy link
Owner Author

mrellipse commented Feb 15, 2018 via email

@bjammin
Copy link

bjammin commented Feb 15, 2018

Thanks very much for looking into this. I'm away from work for the next 1.5 weeks so won't have a chance to look at this until then, but I certainly will!

@hmuhdkamran
Copy link
Collaborator

I have done it, and it work flawlessly, I have also integrated Metronic 5, looking nice

@mrellipse
Copy link
Owner Author

i have actually been toying with the idea of breaking change - to provide support for a small selection of UI frameworks, when you using the yeoman generator for scaffolding (probably html5 boilerplate, bootstrap, material)

it would be a pretty big piece of work - will see how much energy i have in coming weeks :)

@mrellipse
Copy link
Owner Author

superceded by plans for v3 release. no longer current issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Toucan
  
Awaiting triage
Development

No branches or pull requests

3 participants