Skip to content
This repository has been archived by the owner on Jan 24, 2020. It is now read-only.

External auth fails with "invalid nonce" depending on server timezone #21

Closed
bjammin opened this issue Feb 7, 2018 · 1 comment
Closed

External auth fails with "invalid nonce" depending on server timezone #21

bjammin opened this issue Feb 7, 2018 · 1 comment
Assignees
@mrellipse
Labels
bug ready to merge

Comments

@bjammin
Copy link

bjammin commented Feb 7, 2018 •
edited
Loading

It seems the time in the issued nonce is in UTC, but this is being compared against the local time by ExternalAuthController.

Proposed fix:
ExternalAuthController.cs

if (nonce.Created.AddMinutes(30) < DateTime.UtcNow)

Sorry for raising this as an issue, I'm not sure if you're open to pull requests.
@mrellipse mrellipse self-assigned this Feb 11, 2018
@mrellipse mrellipse added the bug label Feb 11, 2018
@mrellipse
Copy link
Owner

coded a fix. will include in deployment for next release

mrellipse added a commit that referenced this issue Jul 15, 2018
@mrellipse
fix : external auth fails with "invalid nonce" depending on server ti…
6482350 
…mezone

#21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrellipse mrellipse

Labels
bug ready to merge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bjammin @mrellipse