Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only flush the link entity, fixes #12 #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Only flush the link entity, fixes #12 #13

wants to merge 1 commit into from

Conversation

tacman
Copy link

@tacman tacman commented Nov 2, 2017

No description provided.

@mremi
Copy link
Owner

mremi commented Nov 2, 2017

Hi @tacman ,

Can you add some unit tests please and add a CHANGELOG.md at the root of the project:

CHANGELOG
=========

2017-11-02
----------

* Fix #12: only flush the given link

@mremi
Copy link
Owner

mremi commented Nov 3, 2017

@tacman pretty sure you'll be able to write some tests looking at the existing ones in https://github.com/mremi/UrlShortenerBundle/blob/master/Tests/Doctrine/LinkManagerTest.php.

Can you please add the CHANGELOG.md I give you above (and squash your commits to have only one).

@mremi
Copy link
Owner

mremi commented Nov 15, 2017

@tacman hi, any news?

@tacman
Copy link
Author

tacman commented Nov 15, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants