Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce MultiMMappedDataInput and create multiple ByteBuffers to me… #104

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

mreutegg
Copy link
Owner

…mory map files bigger than 2 GB

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (927d406) 20.46% compared to head (600195d) 20.92%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #104      +/-   ##
============================================
+ Coverage     20.46%   20.92%   +0.45%     
- Complexity      754      759       +5     
============================================
  Files           170      170              
  Lines         12472    12498      +26     
  Branches       2748     2753       +5     
============================================
+ Hits           2553     2615      +62     
+ Misses         9388     9354      -34     
+ Partials        531      529       -2     
Files Coverage Δ
...hub/mreutegg/laszip4j/laszip/ByteStreamInFile.java 76.19% <100.00%> (+47.07%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oers
Copy link

oers commented Oct 12, 2023

[ERROR] LASReaderTest.readExtraBytesShort:464 expected:<[0.80, 1.12, 1.00, 1.28, 1.52]> but was:<[0,80, 1,12, 1,00, 1,28, 1,52]>
During Build on WIndows

@mreutegg
Copy link
Owner Author

Thanks for reporting the failure. The test depends on the system locale.

@mreutegg
Copy link
Owner Author

Fixed with #105

@sonarcloud
Copy link

sonarcloud bot commented Oct 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

96.7% 96.7% Coverage
0.0% 0.0% Duplication

@mreutegg mreutegg merged commit c33060f into master Oct 19, 2023
9 checks passed
@mreutegg mreutegg deleted the mmap-gt-2gb branch October 19, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants