Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes steps over borders #18

Closed
janmonschke opened this issue Jan 21, 2015 · 4 comments
Closed

Sometimes steps over borders #18

janmonschke opened this issue Jan 21, 2015 · 4 comments

Comments

@janmonschke
Copy link

screen shot 2015-01-21 at 15 13 23

In the y-direction it sometimes steps over borders like this very white image. Is there a way to set a threshold?

@mrflix
Copy link
Owner

mrflix commented Jan 25, 2015

We discussed in #3 but we didn't come up with a satisfying solution on how to change the value UI-wise.

@mrflix
Copy link
Owner

mrflix commented Jul 9, 2015

All-tough judging from your screenshot the error is a different one: it seems that the dimensions screenshot is not in sync with whats on screen. Dimensions takes a screenshot of the visible area whenever it gets activated and then again whenever the user scrolls. When the DOM is changed via Javascript, Dimensions doesn't take a new screenshot. Thats when it gets out of sync and you start to measure invisible dimensions.

Dimensions probably should listen to DOM changes. Any pointers on what DOM events there are?

@mrflix
Copy link
Owner

mrflix commented Jul 9, 2015

add-on: I run into this problem myself very often. To fix it I either press Alt+D twice or scroll a little bit to restart dimensions.

@mrflix
Copy link
Owner

mrflix commented Jul 9, 2015

Merged into #24

@mrflix mrflix closed this as completed Jul 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants