Add a contrast tolerance in options

[adambabik]

It would be nice to have an option to increase/decrease contrast tolerance as for some cases you can get quite strange results. I attached an example where the width is calculate incorrectly.

[mrflix]

We can do this, but we need a good UX solution for this. How would the user change this option on the fly?

[adambabik]

I can imagine that having a slider would do the trick. The problem is how and where show it. Mouse click or gesture can interfere with a web page. On the other hand, selecting the extension icon in order to change this option is not user friendly and might be annoying.

I would try to implement this using, for instance, a double click or double tap. This action could show a slider close to the mouse pointer.

[mrflix]

This makes me think of a long mouse press. What do you think about that?

Showing the slider would freeze the current origin of the dimensions and the threshold changes would get directly visualised.

On 11 Sep 2014, at 16:45, Adam Babik notifications@github.com wrote:

I can imagine that having a slider would do the trick. The problem is how and where show it. Mouse click or gesture can interfere with a web page. On the other hand, selecting the extension icon in order to change this option is not user friendly and might be annoying.

I would try to implement this using, for instance, a double click or double tap. This action could show a slider close to the mouse pointer.

—
Reply to this email directly or view it on GitHub.

[adambabik]

This is great! However, I would go even further. A long mouse button press would show a virtual slider (it would just display the current result) and moving mouse up/down while holding the mouse button would change the option value. Is it the same what you had in mind?

Freezing the current dimensions and live preview when changing the option value is also great in my opinion.

[myfonj]

And what about click+mouse wheel?

BTW, it might be even better to define the "contrast tolerance" not as difference between lightness value of origin area/pixel/point and boundary adept area/pixel/point, but as a minimal difference of two adjacent pixels/points/areas on the path. So path would run through smooth gradients even if they was of wide luminosity range and stop on contrasting border. (Maybe this is what you had in mind already in description; I just wanted to express that. And please pardon my English.)

[adambabik]

Pressing a mouse button and scrolling using the mouse wheel at the same time could be difficult and it's hard to simulate it on touch devices.

I guess that currently it works this way. Check out this part of the code. currentLightness is updated at each step.

[mrflix]

I think the initial problem with ghost borders is linked to #24