Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some things #108

Merged
merged 5 commits into from
Apr 3, 2022
Merged

Fixed some things #108

merged 5 commits into from
Apr 3, 2022

Conversation

YellowZaki
Copy link
Contributor

Fixed:

  • TimeSkipEventListener swapped with SleepSkipEventListener. Versions pre 1.15 were not handling SleepSkipEventListener so the boss bar didn't dissapear, title didn't work, heal/hunger neither...
  • Player#sendTitle() is available from 1.12, not 1.14.
  • night-skipped and storm-skipped titles were not working if the clock counter was enabled, since it was shown before the clock counter title stopped, so it was then overwritten. I've added a 5 ticks delay to show the skipped titles after SleepSkipEventEvent.

Copy link
Owner

@mrgeneralq mrgeneralq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can you elaborate more on the sendTitle and override clock title?
  • I never make a static getter for the Plugin, I would not use this unless you can convince me otherwise

@YellowZaki
Copy link
Contributor Author

  • Can you elaborate more on the sendTitle and override clock title?
  • I never make a static getter for the Plugin, I would not use this unless you can convince me otherwise

When sleeping, the clock animation is sent. As soon as it finishes, SleepSkipEvent is called.
The problem is that if you send the skip night title ("Good morning...") as soon as SleepSkipEvent is called, the clock animation hasn't finished yet, so it overrides the skip night title. Therefore, skip night title was not shown. By delaying the title just 5 ticks, the skip night title can be seen.

I made the getter for the Plugin in order to register the Runnable.

Copy link
Owner

@mrgeneralq mrgeneralq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I approve the changes. These fixes and enhancements will be deployed in V4.15.1.

@mrgeneralq mrgeneralq merged commit 36bc0ec into mrgeneralq:master Apr 3, 2022
@mrgeneralq
Copy link
Owner

mrgeneralq commented Apr 3, 2022

@YellowZaki , please reach out to me on discord
MrGeneralQ# 0001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants