Add api-version to plugin.yml #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this small but useful contribution. It's indeed better to specify the version. |
|
Whoops, looks like specifying the latest api-version broke older versions. I found out that specifying the version as 1.13 instead of 1.16 will work since versions 1.12 and below ignore the api-version field and it will work for 1.13 - 1.15. https://www.spigotmc.org/threads/how-bad-it-is-to-not-specify-an-api-version.420620/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple one-line fix that will get rid of the following warning message on Bukkit/Spigot/Paper:
I set the api-version to 1.16 since sleep-most's SpigotMC resource page lists 1.16 as the native version for the plugin, but it doesn't really matter. Here is the documentation for that attribute.