Add ability to configure STUN & TURN servers in the client. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server can now be configured to fetch a list of ICE servers (both STUN and TURN) from Twilio. If using account credentials, set `TWILIO_ACCOUNT_SID` with the account SID and `TWILIO_AUTH_TOKEN` with the account auth token. If using API keys, set `TWILIO_ACCOUNT_SID` with the account SID, `TWILIO_AUTH_TOKEN` with the API key secret, and `TWILIO_KEY_SID` with the API key SID.
The list of ICE servers for an RTCPeerConnection can be updated using the setConfiguration() method. This only works in Chromium/Safari, not in Firefox. See https://bugzilla.mozilla.org/show_bug.cgi?id=1253706.
An `enabled` property has been added to ICE server objects in the Redux store. This allows us to add empty servers in the UI without passing them to the manager. Then, when a server is saved, it is enabled and can be passed to the manager. Validation (i.e. checking the format of urls and requiring username/credential for TURN servers) will be added in a later commit.
We use basic HTML form validation with the `pattern` and `required` attributes on form inputs. The URLs input must be a comma-separated list of URLs, each prefixed with the server type (i.e. stun: or turn:). Username and password are required fields for TURN servers, but not required for STUN servers.
Instead of having separate bits of state and different actions for TURN and STUN servers, treat everything generically as an ICE server. The `kind` attribute of an ICE server object can be used when TURN and STUN servers need to be treated differently.
And bump development version number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability for users to add, remove, and edit the list of STUN and TURN servers which are used when establishing WebRTC connections.