Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hoisting of symbol properties #18

Closed
Tarabyte opened this issue Jun 17, 2016 · 1 comment
Closed

Support hoisting of symbol properties #18

Tarabyte opened this issue Jun 17, 2016 · 1 comment

Comments

@Tarabyte
Copy link
Contributor

I'm using HOC to annotate components with custom metadata. To avoid name collisions I was planning to use ES2015 Symbols. But this approach fails if component is later wrapped with for example react-redux connect.
Since this library is de facto standard for hoisting statics I thought it would be nice to make it copy symbol properties as Object.assign does.

Made up a PR #17
@Tarabyte
Copy link
Contributor Author

PR was accepted. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tarabyte