Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect AMD definition #89

Closed
staceysern opened this issue Sep 19, 2019 · 2 comments
Closed

Incorrect AMD definition #89

staceysern opened this issue Sep 19, 2019 · 2 comments

Comments

@staceysern
Copy link

The AMD definition does not declare the dependency on react-is and uses the global require, not the AMD local require.

Two possible ways of handling this would be a correct AMD definition here would be either

define(["react-is"], function(ReactIs) {...});

or

define(["require", "react-is"], function(require) { var ReactIs = require("react-is"); ...});

@TrySound
Copy link
Contributor

The fix is in master

@mridgway
Copy link
Owner

Fix is published in v3.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants