TS declaration file is incorrect #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoist-non-react-statics does not have a default export and therefore saying `import hoistStatics from 'hoist-non-react-statics';` raises an expection. Because you're using `module.exports` the correct away to require this package in TS is to say `import hoistStatics = require('hoist-non-react-statics');` but that means that the declaration file is incorrect.
Possible fixes:
1. This change
2. Change the start of [this line](https://github.com/mridgway/hoist-non-react-statics/blob/master/index.js#L35) to `exports.default = modules.exports = ...`
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hoist-non-react-statics does not have a default export and therefore saying
import hoistStatics from 'hoist-non-react-statics';raises an exception in TS 2.4.1. Because you're usingmodule.exportsthe correct away to require this package in TS is to sayimport hoistStatics = require('hoist-non-react-statics');but that means that the declaration file is incorrect.Possible fixes:
exports.default = modules.exports = ...and leave the declaration file as it is.