This repository has been archived by the owner on Aug 18, 2021. It is now read-only.
build and install with same arguments #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mripard
reviewed
Nov 27, 2017
build.sh
Outdated
| @@ -26,7 +26,7 @@ install_driver() { | |||
| local driver_dir=$(pwd)/$RELEASE/src/devicedrv/mali/ | |||
|
|
|||
| USING_UMP=0 BUILD=release USING_PROFILING=0 MALI_PLATFORM=sunxi \ | |||
| USING_DVFS=0 make -C $driver_dir install | |||
| USING_DVFS=1 USING_DEVFREQ=1 make -C $driver_dir install | |||
There was a problem hiding this comment.
Maybe we can just create a global variable that would avoid that kind of issues in the future.
You should also improve your commit log by saying what is happening now, why, and how you are fixing it.
And please provide a Signed-off-by using the kernel's DCO.
There was a problem hiding this comment.
Ok for global variable.
Ok for Commit log and signed-off
Building and installing build driver twice. This is because build_driver() and install_driver() have different make build options. Add global variable for build options unique for both build_driver() and install_driver(). Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build and install with same arguments.
This is to prevent to recompile driver twice.
Issueing:
./build.sh -r r6p2 -b
compiles
./build.sh -r r6p2 -i
compiles again, because arguments passed to Makefile are different then previous command