Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check commit messages in pull requests #30

Closed

Conversation

mristin
Copy link
Owner

@mristin mristin commented Jul 9, 2020

The checks of commit messages in the pull requests were mistakenly
omitted. Previously, only the pull request (header and body) was
examined.

This includes the commits in the checks of the pull request.

The checks of commit messages in the pull requests were mistakenly
omitted. Previously, only the pull request (header and body) was
examined.

This includes the commits in the checks of the pull request.
@mristin mristin force-pushed the mristin/Check-commit-messages-in-pull-requests branch 2 times, most recently from 271f5e4 to 9181163 Compare July 9, 2020 06:36
@mristin mristin force-pushed the mristin/Check-commit-messages-in-pull-requests branch from 9181163 to 57a6ee8 Compare July 9, 2020 06:39
@mristin
Copy link
Owner Author

mristin commented Jul 9, 2020

The github context (github.context.payload?.pull_request) does not include commit messages, but provides only link to them. It would be too tedious to invoke the endpoints to obtain them (needs repo token, fiddling with octokit), so it won't be implemented at the moment.

@mristin mristin closed this Jul 9, 2020
@mristin mristin deleted the mristin/Check-commit-messages-in-pull-requests branch July 9, 2020 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant