Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] unwrap err on rebuild #8

Closed
mrjackwills opened this issue May 20, 2022 · 0 comments
Closed

[BUG] unwrap err on rebuild #8

mrjackwills opened this issue May 20, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@mrjackwills
Copy link
Owner

mrjackwills commented May 20, 2022 •
edited

Describe the bug
If oxker is running, and one rebuilds containers, oxker will error out with a unwrap error, related to app_data mod.rs 308:39

To Reproduce
Steps to reproduce the behavior:

  1. Run oxker in one terminal window
  2. Rebuild running containers in another window, with docker compose pull && docker compose up -d
  3. See error :(

Expected behavior
Oxker should be able to handle rebuilt containers, should be removed from memory, and then re-added once rebuild is complete
@mrjackwills mrjackwills added the bug Something isn't working label May 20, 2022
mrjackwills added a commit that referenced this issue May 30, 2022
@mrjackwills
fix: out of bounds error, closes [#8]
63b7de5 
use .is_some() and if let Some() to make sure that container indexes are still valid, without can cause out of bounds issue due to docker update frequencies
mrjackwills added a commit that referenced this issue May 30, 2022
@mrjackwills
Merge branch 'feat/out_of_bounds' into dev, closes [#8]
4cf02e3
@mrjackwills mrjackwills changed the title [BUG] unwrap err on reubild [BUG] unwrap err on rebuild Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrjackwills