Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Refactor in ibhagwan/fzf-lua main branch does not work with current plugin #137

Open
oeuftete opened this issue Jul 5, 2022 · 2 comments
Labels
help wanted Extra attention is needed result-provider

Comments

@oeuftete
Copy link

oeuftete commented Jul 5, 2022

The refactor in ibhagwan/fzf-lua@817df87 has broken the plugin when using main.

Error detected while processing function <SNR>160_dash_nvim_search:                                                                                                                                                                                                                                    
line    4:                                                                                                                                                                                                                                                                                             
E5108: Error executing lua ...en/.vim/plugged/dash.nvim/lua/dash/providers/fzf-lua.lua:67: attempt to call field 'set_fzf_interactive_cb' (a nil value)                                                                                                                                                
stack traceback:                                                                                                                                                                                                                                                                                       
        ...en/.vim/plugged/dash.nvim/lua/dash/providers/fzf-lua.lua:67: in function 'search'                                                                                                                                                                                                           
        [string "luaeval()"]:1: in main chunk 

Workaround:

        Plug 'ibhagwan/fzf-lua', {'commit': '341f0641ea4b0bd1cb798d7138f1a84c90848b02'}
        Plug 'mrjones2014/dash.nvim', { 'do': 'make install' }
@oeuftete oeuftete changed the title Refactor in ibhagwan/fzf-lua main branch breaks recommended install Refactor in ibhagwan/fzf-lua main branch does not work with current plugin Jul 5, 2022
@mrjones2014 mrjones2014 added help wanted Extra attention is needed result-provider labels Jul 5, 2022
@erikw
Copy link

erikw commented Nov 15, 2022

@oeuftete thanks for reporting.

Is the workaround still working for you? I checked out the above commit in fzf-lua however I still get the same error message. I did make install in the dash.nvim clone after as well.

@mrjones2014
Copy link
Owner

mrjones2014 commented Nov 15, 2022

Sorry I don't really have time to work on this project much between my job and my other plugins with many more users.

Does fzf-lua support hooking into vim.ui.select()? If so, it should be very simple to create a new results provider that uses vim.ui.select() which could be a sufficient workaround. I'd gladly review and merge a PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed result-provider
Projects
None yet
Development

No branches or pull requests

3 participants