slackrIms #13
Closed
slackrIms #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I re-org'd the source before doing this PR but your changes are in! (#ty) and I'm ensuring you have credit in the pkg for all the contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directing messaging from the web API should use im.list instead of users.list
https://api.slack.com/methods/im.list
https://api.slack.com/methods/users.list
The values returned by users.list still works when sending messages, but it does not work for sending files.
This commit is backwards compatible and only uses im.list when necessary. It also includes some unit tests to help with development going forward.
Thanks!