Move test file contents to Svelte #407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes mrlvsb#397. Test files are hidden by default and should be opened manually. The file contents is loaded after the first "unfold" of a card.
Kobzol
reviewed
Dec 7, 2023
There was a problem hiding this comment.
Thanks, this looks great!
I wonder if it's not too much hiding though, because in many cases, the tests are small, and now users will have to do a lot of clicking (and a lot of network requests) to show them.
I think that we might do something like this instead:
- Show the test by default (by inlining the content from Django) if it's "small". "small" should not be 65 KiB, but let's say something up to ~100 lines, so let's say up to 8 KiB.
- If the test is hidden, load it after clicking on the header, and then ignore the inline size limit, and always show the result (the inline part is important to avoid making the whole page HTML too big, but that's not such an issue when we load it lazily).
@geordi What do you think?
Maximum inline bytes is not a constant in frontend anymore. The backend value is passed as a prop instead. Modified the card size to correspond with previous solution. Added missing student URL query.
|
I looked over your review and fixed some issues. Test files are now open by default. However, I was unable to pass file contents from Django effectively (e.g. through slot), since this can be made in component's constructor only by using Svelte's internal methods and I don't find that solution forward compatible. That's why I'm still loading all test files as separate network requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #397.
Test files are hidden by default and should be opened manually. The file contents is loaded after the first "unfold" of a card.