Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for named exports #10

Closed
mrmckeb opened this issue Nov 21, 2018 · 2 comments · Fixed by #22
Closed

Add support for named exports #10

mrmckeb opened this issue Nov 21, 2018 · 2 comments · Fixed by #22
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@mrmckeb
Copy link
Owner

mrmckeb commented Nov 21, 2018

Is your feature request related to a problem? Please describe.
As raised by @fmal, named exports aren't available at present.

Describe the solution you'd like
In theory, with the camelCase option, set to "only" (both in this plugin and CSS Loader), named exports could be created alongside or in place of the default export. This may need another option, such as namedExports (boolean).

Describe alternatives you've considered
The plugin could always export named exports for valid strings, but this would create a confusing developer experience - which is why it may need to be opt-in.

@mrmckeb mrmckeb added enhancement New feature or request good first issue Good for newcomers labels Nov 21, 2018
@mrmckeb mrmckeb self-assigned this Nov 21, 2018
@mrmckeb
Copy link
Owner Author

mrmckeb commented Nov 23, 2018

@fmal Would the above solution be good for your needs?

@fmal
Copy link

fmal commented Nov 23, 2018

@mrmckeb sure, your proposal of making this opt-in and effective only when camelCase is switched on, sounds like the best solution. Thanks for asking 😃

@mrmckeb mrmckeb mentioned this issue Feb 3, 2019
@mrmckeb mrmckeb added this to the v1.1.0 milestone May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants