Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customMatcher support #7

Closed
fmal opened this issue Nov 20, 2018 · 1 comment
Closed

customMatcher support #7

fmal opened this issue Nov 20, 2018 · 1 comment

Comments

@fmal
Copy link

fmal commented Nov 20, 2018

Describe the bug
I can't get the plugin to work when i specify customMatcher such as:

{
  "name": "typescript-plugin-css-modules",
  "customMatcher": "\\.css$"
}

When i leave it off then everything works fine.

To Reproduce
Add "customMatcher": "\\.css$" and use a filename without the .module part (justAFile.css)

Additional context
I quickly browsed the source and noticed that isRelativeCSS helper actually uses the default isCSS predicate: https://github.com/mrmckeb/typescript-plugin-css-modules/blob/develop/src/helpers/cssExtensions.ts#L6. I guess passing overwritten isCSS to isRelativeCSS would solve this issue.

Will look into that later in the evening and submit PR if that is the case 😃

BTW. nice plugin!

fmal added a commit to fmal/typescript-plugin-css-modules that referenced this issue Nov 20, 2018
@mrmckeb
Copy link
Owner

mrmckeb commented Nov 21, 2018

Thanks again @fmal. This is now released.

On your other issue, I think we can discuss here: #10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants