Sometimes tsserver crashes, and typescript-plugin-css-modules stops understanding the classes #41
Comments
|
...According to the stacktrace, looks like createLanguageServiceSourceFile() is sometimes called for the d.ts-alike generated code and not for the original css code. As a very hacky work-around, we may add the following check to getDtsSnapshot() in node_modules/typescript-plugin-css-modules/lib/helpers/cssSnapshots.js: getDtsSnapshot(
ts: typeof ts_module,
fileName: string,
scriptSnapshot: ts.IScriptSnapshot,
options: Options,
) {
const css = scriptSnapshot.getText(0, scriptSnapshot.getLength());
if (css.match(/export default classes/)) {
return scriptSnapshot; // <-- adding this hack
}
const classes = this.getClasses(css, fileName);
const dts = this.createExports(classes, options);
return ts.ScriptSnapshot.fromString(dts);
} |
|
Interesting... Thanks for investigating this. We'll definitely need to investigate this further. I plan to release a new version this weekend, and will see if I can get a fix for this in. |
|
Thanks! Until the fix is released and published to npmjs.com, we have to apply the above hack to lib/helpers/cssSnapshots.js :-) |
|
Unfortunately I ended up in London again on a business trip. @lianapache Can you please try to reproduce this one so that we can verify the fix and get it out? |
Thanks for the awesome commit 143b7ea !
I tried it and turned on verbose logging via TSS_LOG (BTW, for the future googlers, if using Remote - Container extension, the simplest way to set TSS_LOG is to add
environment: - TSS_LOG="-logToFile true -file /tmp/TSS_LOG.txt -level verbose"to docker-compose.yml.)So the problem: sometimes (not always, and it's how I understood the error messages in logs), typescript-plugin-css-modules tries to css-parse not the original css file, but a typescript code generated from it. When doing so, postcss indeed crashes with CssSyntaxError, and it probably crash tsserver or something related to the module (?), so the result is - vscode stops highlighting css classes in the code (although it highlighted them before for ~1 minute):
This probably happens after I Cmd+Click on one of those classes and wait for ~30 seconds after it.
Attaching the full logs below (sorry for them being huge).
The text was updated successfully, but these errors were encountered: