Configurable builder

[flocsy]

To enable creating custom CurlBuilders (for https://github.com/mrmike/Ok2Curl/issues)

public static class MyCurlInterceptor extends CurlInterceptor {
    private static final int[] PARTS_ORDER = new int[]{
            ConfigurableCurlBuilder.PART_CURL,
            ConfigurableCurlBuilder.PART_OPTIONS,
            ConfigurableCurlBuilder.PART_METHOD,
            ConfigurableCurlBuilder.PART_URL,
            ConfigurableCurlBuilder.PART_BODY,
            ConfigurableCurlBuilder.PART_CONTENT_TYPE,
            ConfigurableCurlBuilder.PART_HEADERS
    };

    public MyCurlInterceptor(Loggable logger) {
        super(logger);
    }

    @Override
    protected CurlBuilder getCurlBuilder(Request copy) {
        return new ConfigurableCurlBuilder(copy, limit, headerModifiers, options, delimiter, PARTS_ORDER);
    }
}

Let me know what do you think. I think it can also be merged into CurlBuilder, since we have a default order so we can move all the code in ConfigurableCurlBuilder into CurlBuilder

[C2H6O]

@flocsy any reason not to merge this in?

[flocsy]

you can merge IMHO

[mrmike]

LGTM 👍

[sergeidyga]

@mrmike As far as I understand ConfigurableCurlBuilder is not used in CurlInterceptor constructor now. If so - why it exist?

[mrmike]

Hi @sergeidyga,

You can create your custom Interceptor and override method getCurlBuilder() to return getCurlBuilder. Let's take a look on example from the first post

public static class MyCurlInterceptor extends CurlInterceptor {
    private static final int[] PARTS_ORDER = new int[]{
            ConfigurableCurlBuilder.PART_CURL,
            ConfigurableCurlBuilder.PART_OPTIONS,
            ConfigurableCurlBuilder.PART_METHOD,
            ConfigurableCurlBuilder.PART_URL,
            ConfigurableCurlBuilder.PART_BODY,
            ConfigurableCurlBuilder.PART_CONTENT_TYPE,
            ConfigurableCurlBuilder.PART_HEADERS
    };

    public MyCurlInterceptor(Loggable logger) {
        super(logger);
    }

    @Override
    protected CurlBuilder getCurlBuilder(Request copy) {
        return new ConfigurableCurlBuilder(copy, limit, headerModifiers, options, delimiter, PARTS_ORDER);
    }
}

If you have any more questions I'll be happy to answer them :)

Thanks
Michał

[sergeidyga]

Hi Michał! Thank you for your explanation 🙂 now I see.