-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CoffeeScript + Javascript versions #26
Conversation
@dylan-baskind Nice idea, I actually think it could be really useful if you need to do some color stuff in JavaScript on the fly, but I think it could be a bit simpler. Take a look at the pull request I set up and let me know what you think. You can just call |
Yo @ilanbiala - yah I'm with you! Personally, I prefer accessing JS objects by property keys as well (i.e. colors.aqua) - makes much more sense to me; but most of my code-time these days is with Angular, which seems to work more smoothly iterating over arrays than objects; hence the more vanilla array version. |
@ilanbiala @dylan-baskind Thanks for bringing this up! |
2 similar comments
@ilanbiala @dylan-baskind Thanks for bringing this up! |
@ilanbiala @dylan-baskind Thanks for bringing this up! |
@mrmrs - No worries, pleasure to contribute --- my $0.02: @ilanbiala approach would be my preferred data-model format in any other scenario than Angular's ng-repeat iteration [but I think they might be addressing more palatable object iteration in future releases] - so I think best to go for @ilanbiala 's approach. (PS. @mrmrs - how did no-one think of this before! The browser defaults / defaults in every other-email-text-app-ever are so horrendous. Kudos to you). |
@dylan-baskind - thanks a lot for the honest feedback. Going to close this pull request in favor of @ilanbiala's change. Definitely rock for bringing this up though. |
1 similar comment
@dylan-baskind - thanks a lot for the honest feedback. Going to close this pull request in favor of @ilanbiala's change. Definitely rock for bringing this up though. |
Great project!
I've been using these as the backing-data for a color selection palette in an Angular app, so I thought I'd save people the headache of converting the CSS / LESS / SASS to usable JSON.
Added a Coffeescript + VanillaJS version.
Hopefully useful to others.
D.