Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature to dynamically generate source files #17

Merged
merged 10 commits into from
May 7, 2014

Conversation

rafaelrinaldi
Copy link
Collaborator

PR changelog:

  • Created color_table.json file to store Pesticide's color scheme
  • Created a script that dynamically generates all the source files and already add proper color table to them
  • Created generate build task to run the file generation script

@rafaelrinaldi
Copy link
Collaborator Author

@mrmrs Let me know what you think.

@rafaelrinaldi
Copy link
Collaborator Author

@mrmrs Should I merge this with master?

@mrmrs
Copy link
Owner

mrmrs commented Apr 11, 2014

@rafaelrinaldi - I completely spaced checking this out somehow. Let me take a look this weekend to double check everything. Looks good from the diff but want to run it locally.

@rafaelrinaldi
Copy link
Collaborator Author

@mrmrs
NP bro

@mrmrs
Copy link
Owner

mrmrs commented Apr 15, 2014

@rafaelrinaldi - Functionality is awesome! Thanks so much for this. Couple of requests -
Could we put the json for the colors to element mapping at the project root? Seems like we should make that painfully obvious. Also can you update the readme with a how to on update the color scheme? I know it’s dead simple from the gulp file but I think that some info in the read me will be helpful.

@rafaelrinaldi
Copy link
Collaborator Author

@mrmrs Glad you like it! Will do the changes you've requested and will ping you back.

🍻

@rafaelrinaldi
Copy link
Collaborator Author

@mrmrs Hey! Have a look :)

@rafaelrinaldi
Copy link
Collaborator Author

@mrmrs
crying

@rafaelrinaldi
Copy link
Collaborator Author

@mrmrs
I feel lonely

mrmrs pushed a commit that referenced this pull request May 7, 2014
Added feature to dynamically generate source files
@mrmrs mrmrs merged commit 98d231a into master May 7, 2014
@mrmrs mrmrs deleted the feature/generate_color_table branch May 7, 2014 16:38
@rafaelrinaldi rafaelrinaldi mentioned this pull request May 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants