Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usability in google chrome extension #34

Closed
wants to merge 2 commits into from
Closed

Improve usability in google chrome extension #34

wants to merge 2 commits into from

Conversation

ymatuhin
Copy link

@ymatuhin ymatuhin commented May 9, 2015

When we activate pesticide on any page, we save the state of the pesticide in localstorage. And then when we come back to the page when the pesticide state is true, we automatically activate the pesticide.

@mrmrs
Copy link
Owner

mrmrs commented May 11, 2015

Hey @ymatuhin - thanks a bunch for the pull request.

From what I can tell from your comments and the code changes, this is undesirable behavior for how I want this plug-in to work. If you want pesticide to persist on page reload - it is available as a css module / sass partial for this purpose. You can just toggle the variable or include the css file in the head of your document. The plug-in is for quickly toggling it without the outlines persisting on page reload. Let me know if I am missing something. Thanks again for your effort on this.

@mrmrs mrmrs closed this May 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants