Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add final to variables in immutable classes #1

Closed
menacher opened this issue May 14, 2012 · 2 comments
Closed

Add final to variables in immutable classes #1

menacher opened this issue May 14, 2012 · 2 comments
Milestone
1.0.0

Comments

@menacher
Copy link

AuthorizeMessage and other classes in this package look to be immutable. They do not have setter methods. Adding final to the class variables maybe a good practice. Even the class variables like String, UUID are immutable so this is optional, but can be done for consistency sake.
@mrniko
Copy link
Owner

mrniko commented May 14, 2012

Thanks for comment! I'll fix this.

@mrniko
Copy link
Owner

mrniko commented May 14, 2012

Fixed

@mrniko mrniko closed this as completed May 14, 2012
mrniko pushed a commit that referenced this issue May 14, 2012
Issue #1 fixed
7f0664c
@ctpahhik ctpahhik mentioned this issue Jan 14, 2013
Closed
@michalkijas michalkijas mentioned this issue Mar 3, 2014
Closed
@martinfolkman martinfolkman mentioned this issue Aug 28, 2014
Merged
@evgeny-pasynkov evgeny-pasynkov mentioned this issue Oct 15, 2014
Closed
@dgolovin-dev dgolovin-dev mentioned this issue Dec 1, 2014
Closed
@qchen006 qchen006 mentioned this issue Sep 7, 2016
Closed
@lpage30 lpage30 mentioned this issue Feb 22, 2017
Merged
mrniko pushed a commit that referenced this issue Oct 20, 2018
@zhaolianwang
Merge pull request #1 from zhaolianwang/fix_close_ws
7d59e1c 
fix  null point
YoonsooChang added a commit to simim7/netty-socketio that referenced this issue Jun 7, 2020
@YoonsooChang
Merge pull request mrniko#1 from YoonsooChang/yoonsoo
2cbfece 
Refactoring Scheduler Package => Changed CancelableScheduler From Int…
@hiredman hiredman mentioned this issue Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@menacher @mrniko