Allow authorizing channels which are connected through LocalAddress #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el.local.LocalAddress Local addresses (io.netty.channel.local.LocalAddress) are quite useful as they don't bind to real socket address are less likely to cause unwanted side-effects with other processes. Authorization for socket io clients connecting through local address failed because HandshakeData data was expecting instance of InetSocketAddress.
|
@mrniko can you please also make a release with this fix :) |
|
@mrniko can you please take a look at this PR? |
|
@kshchepanovskyi Done! Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local addresses (io.netty.channel.local.LocalAddress) are quite useful as they don't bind to real socket address are less likely to cause unwanted side-effects with other processes for integration tests and unit tests.
Authorization for socket io clients connecting through local address failed because HandshakeData data was expecting instance of InetSocketAddress.