Yoonsoo #758
Closed
Yoonsoo #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erface To Abstract class And Move Same Codes From Child Classes To Parent. Extract Methods From Scheduling Methods Of HashedWheelScheduler. Added 'final' Keyword To Few Parameters And Local Variables.
Refactoring Scheduler Package => Changed CancelableScheduler From Int…
Revert "Refactoring Scheduler Package => Changed CancelableScheduler From Int…"
- Duplicate Code > HashedWheelScheduler, HashedWheelTimeoutScheduler : Changed CancelableScheduler From Interface To Abstract Class Moving Same Codes From Child Classes(HashedWheel) To Parent(Cancelable). - Extract Methods > addScheduledFuture : Extract duplicated codes from Overrided Funtion HashedWheelScheduler Class - MethodArgumentCouldBeFinal > CancelableScheduler : Put final Keywords to local variable in CancelableScheduler class.
1. rename, extract constants, extract methods 2. namespace/Namespace.java/sendAck(AckRequest) annotation/OnConnectScanner.java/validate(Method, Class<?>) annotation/OnDisConnectScanner.java/validate(Method, Class<?>) annotation/AnnotationScanner.java/validate(Method, Class<?>) annotation/OnConnectScanner.java/validate(Method, Class<?>) annotation/OnDisConnectScanner.java/validate(Method, Class<?>) annotation/OnEventScanner.java/validate(Method, Class<?>) store/pubsub/BaseStoreFactory.java/init()/subscribe(CONNECT) store/pubsub/BaseStoreFactory.java/init()/subscribe(DISPATCH) store/pubsub/BaseStoreFactory.java/init()/subscribe(LEAVE) store/RedissonPubSubStore.java/subscribe(PubSubType, PubSubListener<T>...) store/RedissonPubSubStore.java/unsubscribe(PubSubType) Configuration.java 3. to increase readability
1. rename, extract constants, extract methods 2. namespace/Namespace.java/sendAck(AckRequest) annotation/OnConnectScanner.java/validate(Method, Class<?>) annotation/OnDisConnectScanner.java/validate(Method, Class<?>) annotation/AnnotationScanner.java/validate(Method, Class<?>) annotation/OnConnectScanner.java/validate(Method, Class<?>) annotation/OnDisConnectScanner.java/validate(Method, Class<?>) annotation/OnEventScanner.java/validate(Method, Class<?>) store/pubsub/BaseStoreFactory.java/init()/subscribe(CONNECT) store/pubsub/BaseStoreFactory.java/init()/subscribe(DISPATCH) store/pubsub/BaseStoreFactory.java/init()/subscribe(LEAVE) store/RedissonPubSubStore.java/subscribe(PubSubType, PubSubListener<T>...) store/RedissonPubSubStore.java/unsubscribe(PubSubType) Configuration.java 3. to increase readability
pull request after refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.