clean-up & update #123
Merged
clean-up & update #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #118 the hf.stats function prints the incorrect url when it requests data. This fix will print the correct URL. None of the other functions in this module are affected.
fix URL print out for hf.stats
fix url for stat service request
Fix docstrings so that they work again. Fixes issue #120
Bug pandas catchup
remove Python 3.6 from test suite
I changed how I update the version too: the version is only stored in __init__.py and setup.cfg grabs it with attr: hydrofunctions.__version__
removes 3.6 adds 3.10 & 3.11
Pandas removed .is_monotonic and replaced with .is_monotonic_increasing. This fixes three tests and labels; plus a dataset.
Thank you @jmccreight !
fix index.week --> list(index.isocalendar().week)
Move to latest actions:
checkout@v2 -->v3
setup-python@v2-->v4
codecov-actions@v1-->v3
plus make verbose, add name
Update actions:
checkout@v2 --> v3
setup-python@v2 --> v4
pypa/gh-action-pypi-publish@master
--> release/v1
and add verbose: true to help with twine debug
Update action version numbers:
checkout@v2 --> v3
setup-python@v2 --> v4
pypa/gh-action-pypi-publish@master
--> release/v1
add verbose: true to help debug twine failures
These haven't been necessary for years...
Remove old cruft, such as: #!/usr/bin/env python # -*- coding: utf-8 -*- Standardize the header for test modules and the fixtures.
Ignore long lines
3.10 gets parsed as 3.1 and then fails...
Only upload to CodeCov once; don't fail job if upload fails.
Pandas 2. requires 3.8+
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
- Coverage 97.34% 97.23% -0.12%
==========================================
Files 19 18 -1
Lines 1394 1373 -21
==========================================
- Hits 1357 1335 -22
- Misses 37 38 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest changes mostly clean files, update the github actions, and repair compatibility with Pandas 2. It loses Python 3.7 and 3.8