Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legend, legend_loc, and title params to charts #61

Merged
merged 4 commits into from
Nov 28, 2019

Conversation

mroberge
Copy link
Owner

Fixes #60, which @mopickel pointed out.

@codecov-io
Copy link

codecov-io commented Nov 28, 2019

Codecov Report

Merging #61 into develop will increase coverage by 3.98%.
The diff coverage is 90%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #61      +/-   ##
===========================================
+ Coverage    82.74%   86.72%   +3.98%     
===========================================
  Files            8        8              
  Lines          562      565       +3     
  Branches       105      108       +3     
===========================================
+ Hits           465      490      +25     
+ Misses          65       48      -17     
+ Partials        32       27       -5
Impacted Files Coverage Δ
hydrofunctions/charts.py 85.57% <90%> (+22.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf1f296...9e3eb0c. Read the comment docs.

@mroberge mroberge merged commit 698e97e into develop Nov 28, 2019
@mroberge mroberge deleted the add-chart-params branch November 28, 2019 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants