Fix WCDMA typos #43
Merged
Fix WCDMA typos #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patyizsolt
approved these changes
Jun 5, 2022
patyizsolt
approved these changes
Jun 5, 2022
patyizsolt
approved these changes
Jun 5, 2022
patyizsolt
approved these changes
Jun 5, 2022
patyizsolt
approved these changes
Jun 5, 2022
patyizsolt
approved these changes
Jun 5, 2022
patyizsolt
approved these changes
Jun 5, 2022
Wa37eD
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SignalWcdma.kt
Change from ECNO_MIN to ECIO_MIN
CellMapperWcdma
Compare dbm to asu instead of asu to itself.
Note: I'm not sure what the purpose of the comparison is since it looks like we could just always return the
dbm ?: asustatement if the idea is to fall back to asu when dbm is null, but regardless I've kept the original logic for now