-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari - Invalid Regular Expression - Invalid Group Specifier Names #197
Comments
Thanks for reporting this @CodesAreHonest. I'll work on getting a fix out for this very soon. I'll post back with an update once I have a new release published to NPM that fixes this. |
Appreciate your response on this issue, looking forward for the fixes and thanks for the awesome library ! |
As reported in mrodrig/json-2-csv#197, many browsers don't support negative look behind RegExps, which causes both calls to this module and dependency modules to fail when that logic was invoked. In order to fix that, this commit reworks the RegExp to be use a string character parser to find first index where a non-escaped '.' character is found.
As reported in mrodrig/json-2-csv#197, many browsers don't support negative look behind RegExps, which causes both calls to this module and dependency modules to fail when that logic was invoked. In order to fix that, this commit reworks the RegExp to be use a string character parser to find first index where a non-escaped '.' character is found.
* Remove negative lookbehind regexp logic. As reported in mrodrig/json-2-csv#197, many browsers don't support negative look behind RegExps, which causes both calls to this module and dependency modules to fail when that logic was invoked. In order to fix that, this commit reworks the RegExp to be use a string character parser to find first index where a non-escaped '.' character is found. * chore(release): 3.0.1
As reported in #197, there was a compatibility issue introduced in doc-path@3.0.0 where a negative lookbehind Regexp was being used despite not being supported by many browsers. This caused runtime errors when this library's functionality was called due to the underlying dependency compatibility issue. This commit bumps the version to 3.0.1 which fixes the compatibility issue in the doc-path module. Fixes #197
* Update doc-path to fix negative lookbehind regexp. As reported in #197, there was a compatibility issue introduced in doc-path@3.0.0 where a negative lookbehind Regexp was being used despite not being supported by many browsers. This caused runtime errors when this library's functionality was called due to the underlying dependency compatibility issue. This commit bumps the version to 3.0.1 which fixes the compatibility issue in the doc-path module. Fixes #197 * chore(release): 3.14.1
Thanks again for reporting this @CodesAreHonest. The fixed version should be up on NPM now as version |
My pleasure to help, the latest version work like charm in the Safari environment. Much appreciated. |
Background Information
3.14.0
16.1.0
The issue I'm reporting is with:
I have...
Expected Behavior
Actual Behavior
The browser complains the error (refer screenshot above) due to Lookbehind Regex does not support in Safari.
Discussion
The library use
doc-path
as dependencies.Refer this line, the function
state
use Negative Lookbehind Regex to performexec
leads to the mentioned errors and break in the browser.The text was updated successfully, but these errors were encountered: