Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type error and docs conflict #177

Merged
merged 2 commits into from
Jan 1, 2021
Merged

fix: type error and docs conflict #177

merged 2 commits into from
Jan 1, 2021

Conversation

rsgok
Copy link
Contributor

@rsgok rsgok commented Dec 30, 2020

Background Information

I have...

  • added at least one test to verify the failure condition is fixed.
  • verified the tests are passing.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 95d017f on LandingWind:stable into 995ff6b on mrodrig:stable.

@mrodrig
Copy link
Owner

mrodrig commented Jan 1, 2021

Thanks for finding and fixing this @LandingWind. I'll get this merged in and will push a new release to NPM in a little bit.

@mrodrig mrodrig merged commit 254e1cf into mrodrig:stable Jan 1, 2021
mrodrig added a commit that referenced this pull request Jan 1, 2021
@mrodrig
3.10.1, merges in #177
258f048
@mrodrig mrodrig added this to the 3.10.1 milestone Jan 1, 2021
@mrodrig
Copy link
Owner

mrodrig commented Jan 1, 2021

Thanks again for fixing this and sorry for the issue in the first place. It should be published on NPM in 3.10.1 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.10.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rsgok @coveralls @mrodrig