Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In compatible with Zotero 6.0 #44

Open
tenglu0417 opened this issue Mar 7, 2022 · 24 comments · May be fixed by #46
Open

In compatible with Zotero 6.0 #44

tenglu0417 opened this issue Mar 7, 2022 · 24 comments · May be fixed by #46

Comments

@tenglu0417
Copy link

The plugin seems to be incompatible with the Zotero beta.
image

Repository owner deleted a comment from lbc1027 Mar 8, 2022
@bwiernik
Copy link
Collaborator

bwiernik commented Mar 8, 2022

This plugin is not currently being maintained. The new PDF reader is much faster than QuickLook ever was. I will accept pull requests to fix the issues needed to make the plugin functional again, but I'm not going to spend time to fix them myself

@jf---
Copy link

jf--- commented Mar 20, 2022

On osx, being able to page / leaf through your documents via ZoteroQuickLook does make browsing quite a pleasure.
The immediacy of access is really key for doing research.

So when you need to page through a nr of documents ZoteroQuickLook still presents a huge advantage over opening the file in a reader. In terms of browsing, nothing really has changed, since either opening in the new reader or in Preview.app pretty much is the same latency.

@AddictArts
Copy link

AddictArts commented Mar 21, 2022

@tenglu0417 Please consider a rename to remove the "beta", thanks in advance.

For Mac OS, it appears initScripts or initExecutable is no longer properly completing, the functions. When openQuickLook gets called the this.viewerBaseArguments and this.viewerExecutable are null.

I was able to fix it for Mac by putting this in to set the values.

        this.viewerBaseArguments=['-p'];
        this.viewerExecutable = Zotero.File.pathToFile("/usr/bin/qlmanage");

right after

	openQuickLook: async function(items) {

Note: the install.rdf update to 6.0.* for the maxVesion for the target.

I don't have time to create a proper fork and pull request. Cheers

@bwiernik
Copy link
Collaborator

As I've said multiple times, I am happy to accept a pull request if someone wants to make the plugin compatible with Zotero 6, but I don't have the time to make the updates myself. If you have done so, please submit a pull request.

@zoelir729
Copy link

zoelir729 commented Mar 23, 2022

@tenglu0417 Please consider a rename to remove the "beta", thanks in advance.

For Mac OS, it appears initScripts or initExecutable is no longer properly completing, the functions. When openQuickLook gets called the this.viewerBaseArguments and this.viewerExecutable are null.

I was able to fix it for Mac by putting this in to set the values.

        this.viewerBaseArguments=['-p'];
        this.viewerExecutable = Zotero.File.pathToFile("/usr/bin/qlmanage");

right after

	openQuickLook: async function(items) {

Note: the install.rdf update to 6.0.* for the maxVesion for the target.

I don't have time to create a proper fork and pull request. Cheers

It works in Mac.
And sorry to ask, the Chinese.pdf can not be opened, how to sovle it ?
Thanks!
image

@cannolis
Copy link

@zoelir729 @AddictArts Thank all of you for discussing and fixing the issue. But I'm new to Zotero and don't actually understand where to put the code in. Could you please tell me more details about it?

@tenglu0417 tenglu0417 changed the title In compatible with Zotero 6.0 beta In compatible with Zotero 6.0 Mar 24, 2022
@mronkko
Copy link
Owner

mronkko commented Mar 24, 2022

If you are new to Zotero it is probably not a good idea to start making changes to the code.

I originally developed the plugin and was using it actively until upgrading to Zotero 6. I see value in the ability browse through articles with quicklook and this is not something that the built-in viewer provides. I will probably fix this at some point, but given that this is a side project it is difficult to say when that might be.

@cannolis
Copy link

@mronkko Thanks! We will deeply appreciate your help and look forward to the new ZoteroQuickLook Plugin.

@zoelir729
Copy link

image

image

image

image

Zip these files (Do not zip the upper level folder), and change the .zip into the .xpi.

@phguo
Copy link

phguo commented Mar 25, 2022

@zoelir729 A temporary solution:

Tools -> ZotFile Preferences -> Advanced Settings -> "☑️rename special characters (diacritics) from file name"

Update:

Works for non English non Chinese file name, but still does not work for Chinese file name.

@tenglu0417 Please consider a rename to remove the "beta", thanks in advance.
For Mac OS, it appears initScripts or initExecutable is no longer properly completing, the functions. When openQuickLook gets called the this.viewerBaseArguments and this.viewerExecutable are null.
I was able to fix it for Mac by putting this in to set the values.

        this.viewerBaseArguments=['-p'];
        this.viewerExecutable = Zotero.File.pathToFile("/usr/bin/qlmanage");

right after

	openQuickLook: async function(items) {

Note: the install.rdf update to 6.0.* for the maxVesion for the target.
I don't have time to create a proper fork and pull request. Cheers

It works in Mac. And sorry to ask, the Chinese.pdf can not be opened, how to sovle it ? Thanks! image

@cannolis
Copy link

@zoelir729 I truly appreciate your timely help!

@cannolis
Copy link

@zoelir729 I have a quick look at the file named zoteroquicklook.js, and just after I remove the code as below in the function cleanFileName, the plugin works well for the Chinese file name.

    if (this.getPref("usefilenameworkaround") && ! Zotero.isWin){
    filename=filename.replace(/[^A-Z0-9.:\/\\_\- ]/gi,'*');
    }

@zoelir729
Copy link

@zoelir729 I have a quick look at the file named zoteroquicklook.js, and just after I remove the code as below in the function cleanFileName, the plugin works well for the Chinese file name.

    if (this.getPref("usefilenameworkaround") && ! Zotero.isWin){
    filename=filename.replace(/[^A-Z0-9.:\/\\_\- ]/gi,'*');
    }

It works.
Thanks!

@iseesaw
Copy link

iseesaw commented Apr 17, 2022

Good job!!

@Regulust
Copy link

Regulust commented Apr 17, 2022

I tried to modify the code by following the discussions above to make ZoteroQuickLook work with Zotero 6.x in this fork version, which can be downloaded and installed directly. Thanks for all good comments above.

Also Have found another new fork version - ZoteroQuickLookReload which is compatible with Zotero 6.x too. Guys could test the compatibility on your system. (Change the extension name to .xpi or .zip to install on Zotero 6.x)

@lbc1027
Copy link

lbc1027 commented Apr 17, 2022 via email

Regulust added a commit to Regulust/ZoteroQuickLook that referenced this issue Apr 17, 2022
For compatibility with Zotero 6.x.
Refer to [issuecomment](mronkko#44 (comment)) and [comment](mronkko#44 (comment)).
@beaugunderson
Copy link

beaugunderson commented Jun 13, 2022

I have forked the project again because ZoteroQuickLookReload (the fork mentioned above) does not provide an un-obfuscated version of the source and I was worried about running it on my system.

My version is here (and only supports macOS): https://github.com/beaugunderson/ZoteroQuickLookNG

@eliasgalvan305
Copy link

That was my favorite way to quick check files. Hopefully we can get working again. I am not a MAC user at the moment =(

@cwwalter
Copy link

Thanks for this @beaugunderson! I had the same worry. I found I could make the old version work just by changing the target version, but I see you did a lot of cleanup and removed calling the perl file. Your version also seems more responsive on my system.

YaoLiMuMu added a commit to YaoLiMuMu/ZoteroQuickLook that referenced this issue Jun 14, 2023
…w focus in Linux

//
<zoteroquicklook.pl> a bug fix that preventing the new sushi preview window from losing window focus
<.gitignore>: ignore .xpi/.zoteroplugin files for version management
<linux_build.sh>: add shell script to perform auto-pack for .xpi plugin, compatiale with Zotero 6.0
<README.md>: modify installing section and the part description of non-Windows system
	1) installation note for zotero 6.0
	2) add path check for quicklook application
	3) Gnome Suhi installation guide
<.rdf> update zotero6.0 version support and update plugin version numbers to 1.4.3
//
Close mronkko#44, mronkko#43
YaoLiMuMu added a commit to YaoLiMuMu/ZoteroQuickLook that referenced this issue Jun 14, 2023
…w focus in Linux

//
<zoteroquicklook.pl> a bug fix that preventing the new sushi preview window from losing window focus
<.gitignore>: ignore .xpi/.zoteroplugin files for version management
<linux_build.sh>: add shell script to perform auto-pack for .xpi plugin, compatiale with Zotero 6.0
<README.md>: modify installing section and the part description of non-Windows system
        1) installation note for zotero 6.0
        2) add path check for quicklook application
        3) Gnome Suhi installation guide
<.rdf> update zotero6.0 version support and update plugin version numbers to 1.4.3
//
Close mronkko#44, mronkko#43
YaoLiMuMu added a commit to YaoLiMuMu/ZoteroQuickLook that referenced this issue Jun 14, 2023
…w focus in Linux

//
<zoteroquicklook.pl> a bug fix that preventing the new sushi preview window from losing window focus
<.gitignore> ignore .xpi/.zoteroplugin files for version management
<linux_build.sh> add shell script to perform auto-pack for .xpi plugin, compatiale with Zotero 6.0
<README.md> modify installing section and the part description of non-Windows system
        1) installation note for zotero 6.0
        2) add path check for quicklook application
        3) Gnome Suhi installation guide
<.rdf> update zotero6.0 version support and update plugin version numbers to 1.4.3
<TODO> list Bugs/Low-priority bugs/Ideas
//
Close mronkko#44, mronkko#43
@joaofrgomes
Copy link

I have forked the project again because ZoteroQuickLookReload (the fork mentioned above) does not provide an un-obfuscated version of the source and I was worried about running it on my system.

My version is here (and only supports macOS): https://github.com/beaugunderson/ZoteroQuickLookNG

Hi! I have been using one of the multiple QuickLook extensions with Zotero 6 but now, with the advent of Zotero 7, it seems they, too, will break. Do you have any plans on updating your own for the upcoming version? Thanks!

@lbc1027
Copy link

lbc1027 commented Sep 14, 2023 via email

@occasional15
Copy link

Zotero 7 联用QuickLook的解决方法(A solution for using QuickLook in Zotero 7 or 6):https://mp.weixin.qq.com/s/wlwzEsbxjTOctLdWZk_g_w

@lbc1027
Copy link

lbc1027 commented Oct 17, 2023 via email

@dschaehi
Copy link

Another solution for using QuickLook for Zotero 7 can be found here: #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet