New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aborting query is not supported #344
Comments
I also checked how long groonga process took by srv/mariadb/groonga.log with 5 seconds timeout, but terminated in 9.8 seconds
and here groonga takes 8.2 seconds. without timeout, finished in 18.1 seconds
and here groonga takes 8.2 seconds. So it seems that whole groonga process is executed regardless query timeout in MariaDB side. |
I've implemented this. :-) |
NexediGitlab
pushed a commit
to SlapOS/slapos
that referenced
this issue
Nov 7, 2022
with support for aborting query ( mroonga/mroonga#344 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
MariaDB has
max_statement_time
variable with which any query taking longer than this time (seconds) will be aborted. MySQL also hasmax_execution_time
variable with which SELECT query taking longer than this time (millseconds) will be aborted.Currently, these values do not affect Mroonga, thus queries will be aborted after whole mroonga process finishes. So if we get lots of queries which match too many results, it can cause DoS.
Here are MariaDB implementation for this functionality (by @kou) :
Groonga supports request timeout but it cannot be used from Mroonga for now.
The text was updated successfully, but these errors were encountered: