Enable to change font #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default font `Impact.ttf` can't print non-alphanumeric characters
like Japanese, Chinese, and so on. So I want to set another one.
example)
lolcommits --capture --test -m '笑' -f /Library/Fonts/Osaka.ttf
or
export LOLCOMMITS_FONT="/Library/Fonts/Osaka.ttf"
lolcommits --capture --test -m '笑'
`笑` means `lol` in Japanese :)
|
This is awesome! It looks like it's causing the tests to fail however... any idea why? |
runner is nil at `lolcommits --plugins`
|
Now tests passed at ruby 1.8.7 and 1.9.2, but failed at 1.9.3 :( |
I think this feature is unstable. |
|
Yes, I agree, it seems like builds randomly fail on that test on travis-ci but then pass when being re-run. I have no idea why however. I'm going to just disable that test for now until I can debug it. |
|
This looks great, thanks for much! Merging for v0.4.1 release. You might want to add the documentation to the wiki page here as well: https://github.com/mroth/lolcommits/wiki/Configuration-Variables |
|
Thank you for merging!! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default font
Impact.ttfcan't print non-alphanumeric characterslike Japanese, Chinese, and so on. So I want to set another one.
example)
or
笑meanslolin Japanese :)