Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reentrancy Crash on start in iOS with install method #574

Closed
judastheo opened this issue Aug 23, 2023 · 3 comments
Closed

Reentrancy Crash on start in iOS with install method #574

judastheo opened this issue Aug 23, 2023 · 3 comments

Comments

@judastheo
Copy link

Hello,

We have been using react-native-mmkv for almost two years with a very good experience, using it coupled with redux-persist.

While switching from unimodules to new expo integration, introducing more JSI cool architecture stuff, we end up having our app crash on start on iOS.

package.json

    "expo": "48.0.20",
    "react-native-mmkv": "2.10.1",

Error

Looking at the issue and based on analog discussion found here, our understanding is that in the MMKVModule, it seems that it's a thread issue linked to the use of RCT_EXPORT_BLOCKING_SYNCHRONOUS_METHOD for the install method, that React-Native does not recommend.

We tried to come up with simple workarounds but changing the method to make not synchronous and potentially solve the thread issue but failed due to the lack of deep understanding of the library on our part.

Screenshot

image

Is this issue reproductible on your side or do you have a workaround? Do not hesitate if you need more precision!

Thanks for the library, have a good day!

@mrousavy
Copy link
Owner

Hey! Glad to hear you've been using my library for over 2 years without any problems 😄

I don't know where that Expo issue is coming from, I'm just guessing that they changed the threading and/or order of execution in synchronous methods, but I am not using Expo in any of my apps at the moment so I don't experience the same bug.

If you find a solution don't hesitate to send a PR and I'll gladly review/merge.

If you don't, we're happy to make this work for you through my agency, Margelo :)

@WJimmyCook
Copy link

Did you ever figure this out @judastheo ?

@mrousavy
Copy link
Owner

Hey - I think this has been fixed in V3 beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants