Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for AGP>=8 #589

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

AlirezaHadjar
Copy link
Contributor

Added support for AGP version 8 and above to fix build issues on RN v0.73

@mrousavy
Copy link
Owner

Awesome, thanks! Let's see if the CI runs :)

@AlirezaHadjar
Copy link
Contributor Author

@mrousavy I'm not sure what broke the lint report step. Do you have any idea how to fix it?

@mrousavy
Copy link
Owner

Hm, idk - I'm not sure if those artefacts are uploaded - can you try running those steps locally?

@AlirezaHadjar
Copy link
Contributor Author

@mrousavy I think there's something wrong with the Validate Android / Gradle Lint (pull_request). This issue also exists in many merged PRs: #550 #512 #499 #480. Apparently Validate Android / Gradle Lint (pull_request) always fails.

Let me know if I need to do anything 🙂

@mrousavy
Copy link
Owner

Okay yea true, I think then that CI is broken! Thanks, LGTM!

@mrousavy mrousavy merged commit 01b2bb2 into mrousavy:master Oct 23, 2023
2 of 3 checks passed
@AlirezaHadjar AlirezaHadjar deleted the feat/agp-8 branch November 11, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants