Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-process mode #639

Closed
wants to merge 2 commits into from
Closed

multi-process mode #639

wants to merge 2 commits into from

Conversation

CristiCeban
Copy link

This PR:

  • add multi-process mode for android (all hail to this PR).
  • add option to disable multi-process for iOS if AppGroup is present in bundle. Needed for this. Now if an application has AppGroup set for some reason and does not want to save the data in the appGroup location, it will be able to use the default mmkv location by setting mode:single-process.
  • update the documentation on the mode configuration.
  • update the example app to work with xcode 15.

I'm not sure about moving the RCTUnsafeExecuteOnMainQueueSync() function to the createFromHostFunction() function. I've tested it on iOS and it seems to work without problems. I attach the video:

Screen.Recording.2024-02-27.at.15.43.47.mov

@mrousavy
Copy link
Owner

Hey, thanks so much for your PR, this is really exciting. I am a bit swamped with work right now, so it might take a few days before I can review this, hope you understand!

@CristiCeban
Copy link
Author

I'm closing this PR because v3 is supporting MULTI_PROCESS and SINGLE_PROCESS mode

@mrousavy
Copy link
Owner

Hey - shit sorry I forgot to get back to this PR now.

Thanks so much for this, yea I added this to V3 already (with an enum now not a TS union, but this is for some reason broken in CodeGen), so this is now obsolete. Thank you tho!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants