Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove MMKV/ submodule copy #672

Merged
merged 4 commits into from
Apr 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 2 additions & 2 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[submodule "MMKV"]
[submodule "package/MMKV"]
path = package/MMKV
url = https://github.com/Tencent/MMKV.git
url = https://github.com/Tencent/MMKV
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ We want this community to be friendly and respectful to each other. Please follo

## Development workflow

To get started with the project, run `npm i` in the root directory to install the required dependencies for each package:
To get started with the project, run `npm i` in the `package/` directory to install the required dependencies for each package:

```sh
yarn
Expand All @@ -20,7 +20,7 @@ If you want to use Android Studio or XCode to edit the native code, you can open

To edit the Java or Kotlin files, open `example/android` in Android studio and find the source files at `react-native-mmkv` under `Android`.

You can use various commands from the root directory to work with the project.
You can use various commands from the `package/` directory to work with the project.

To start the packager:

Expand Down
1 change: 1 addition & 0 deletions package/MMKV
Submodule MMKV added at 9a210a
36 changes: 0 additions & 36 deletions package/MMKV/.clang-format

This file was deleted.

14 changes: 0 additions & 14 deletions package/MMKV/.github/FUNDING.yml

This file was deleted.

45 changes: 0 additions & 45 deletions package/MMKV/.github/ISSUE_TEMPLATE/bug_report.md

This file was deleted.

52 changes: 0 additions & 52 deletions package/MMKV/.gitignore

This file was deleted.

3 changes: 0 additions & 3 deletions package/MMKV/.gitmodules

This file was deleted.

12 changes: 0 additions & 12 deletions package/MMKV/Android/MMKV/.gitignore

This file was deleted.

54 changes: 0 additions & 54 deletions package/MMKV/Android/MMKV/build.gradle

This file was deleted.

Loading
Loading